-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation styling #4227
Conversation
I just want to point out that this PR targets |
@ghislaineguerin This looks great! Feedback
AdmonitionCode Block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
@kgodey I've pushed additional styling changes. I'm not sure if you wanted me to completely change the admonitions or fix anything in particular? |
@ghislaineguerin I looked at the code blocks and admonitions and I think they look good 👍 I had a question about font size. I feel like the new fonts are "bigger" at the same font size value as the previous site, and that the new styles look a lot better if the base font size is reduced from .8em to .7em: Old site (.8em)New site (.8em)New site (.7em)What do you think? I also think we can probably merge this at this point, once you're replied about the font size. |
@zackkrida I agree about the font size, I'm ok with making that change and merging it. |
@ghislaineguerin I made the change and merged; thanks! |
Updates Documentation Styles to match new marketing site:
NOW:
BEFORE: