Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new PageTracer functionalities #171

Merged
merged 11 commits into from
Oct 22, 2024

Conversation

vidyasilai
Copy link
Collaborator

@vidyasilai vidyasilai commented Oct 15, 2024

  • This PR refactors the trace_refs_recursive function to use a new interface called PageTracer. This is the first step in a solution to the issue described in Eliminate redundant page loads when tracing outgoing references  #170, with the new functionality being encapsulated in the PageTracer class.
  • Subsequent PRs will implement the actual logic to avoid the redundant page load.

Copy link
Collaborator

@tonyastolfi tonyastolfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR... lots to like in this one wrt completeness and good style!

I would like to resolve some high-level design concerns before moving ahead. Please read my comment on page_tracer.hpp and LMK what you think.

src/llfs/page_tracer.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@tonyastolfi tonyastolfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for the most part, just a few minor comments. I really appreciate the attention paid to designing and implementing a comprehensive test case!

src/llfs/page_device_cache.cpp Outdated Show resolved Hide resolved
src/llfs/page_tracer.cpp Outdated Show resolved Hide resolved
src/llfs/page_tracer.cpp Outdated Show resolved Hide resolved
src/llfs/page_tracer.hpp Show resolved Hide resolved
src/llfs/page_tracer.hpp Show resolved Hide resolved
src/llfs/page_tracer.hpp Outdated Show resolved Hide resolved
src/llfs/page_tracer.test.cpp Show resolved Hide resolved
src/llfs/page_tracer.test.cpp Outdated Show resolved Hide resolved
src/llfs/page_tracer.test.cpp Show resolved Hide resolved
@tonyastolfi tonyastolfi merged commit 711729a into mathworks:main Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants