-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new PageTracer functionalities #171
Introduce new PageTracer functionalities #171
Conversation
…' (performed by upgrade-script.sh).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR... lots to like in this one wrt completeness and good style!
I would like to resolve some high-level design concerns before moving ahead. Please read my comment on page_tracer.hpp and LMK what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great for the most part, just a few minor comments. I really appreciate the attention paid to designing and implementing a comprehensive test case!
trace_refs_recursive
function to use a new interface calledPageTracer
. This is the first step in a solution to the issue described in Eliminate redundant page loads when tracing outgoing references #170, with the new functionality being encapsulated in thePageTracer
class.