Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #40 and #42 #43

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fixes issue #40 and #42 #43

merged 3 commits into from
Feb 4, 2025

Conversation

tsharmaMW
Copy link
Member

@tsharmaMW tsharmaMW commented Jan 29, 2025

Resolves #40 , Resolves #42

Here's a few snapshots:
image

Edit:
Reverted the prefix addition for the MBT task to maintain consistency across all plugins.
image

@sameagen-MW
Copy link
Member

It seems like the naming pass decision for GHA was to just use the task name without context. To keep the plugins consistent, it's probably best to leave it as just the task name for now despite my preferences. I'll mesage you with the confluence link.

@tsharmaMW
Copy link
Member Author

It seems like the naming pass decision for GHA was to just use the task name without context. To keep the plugins consistent, it's probably best to leave it as just the task name for now despite my preferences. I'll mesage you with the confluence link.

Alright, it definitely makes sense to maintain consistency across all the plugins. I'll update the PR and also close issue #42.

Copy link
Member

@mw-kapilg mw-kapilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@tsharmaMW tsharmaMW merged commit dae7f0e into main Feb 4, 2025
3 checks passed
@tsharmaMW tsharmaMW deleted the fix_issues branch February 4, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants