Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix major doc typo #2

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Fix major doc typo #2

merged 1 commit into from
Oct 22, 2019

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Oct 22, 2019

When cfg(debug_assertions) is enabled/true, DebugDropBomb is a RealBomb. When cfg(debug_assertions) is disabled/false, DebugDropBomb is a FakeBomb.

Given the potential confusion here, it might be better to use "When debug assertions are disabled (e.g. in release mode)" than "When #[cfg(debug_assertions)] is disabled", but I stuck with the existing verbiage initially.

@matklad
Copy link
Owner

matklad commented Oct 22, 2019

Oh yeah, that was one clunky phrasing, thanks!

@matklad matklad merged commit 36b4bee into matklad:master Oct 22, 2019
@CAD97 CAD97 deleted the patch-2 branch October 22, 2019 22:45
@matklad matklad mentioned this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants