fix member accessors #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually this has a problem, it's handling all MemberExpressions, not just ones at the end of line. 😕 Will keep trying! |
|
Is it working as expected after your new commits? Thanks for trying! |
|
@feross: Yes! Ran it on audio-slot and everything looks great now. |
|
Released as 1.6.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #72
Running on the following file produces an esprima parse error:
This is because there is no handler for
MemberExpressionClosingand it is getting converted to:This PR adds a test for this case and rule for adding a newline after
MemberExpressionClosing.