Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy resources to given namespace #35

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

rbjorklin
Copy link
Contributor

By specifying the namespace in the manifests they can't be deployed to the wrong namespace by accident. I found this useful when iterating locally.

@rbjorklin rbjorklin force-pushed the deploy-resources-to-given-namespace branch from 86af1e4 to 744d097 Compare November 27, 2024 21:31
@mboersma mboersma self-assigned this Dec 23, 2024
@mboersma mboersma requested a review from dtzar January 2, 2025 02:31
@mboersma
Copy link
Owner

mboersma commented Feb 1, 2025

@dtzar does this look like a reasonable change to you?

@rbjorklin could you increment the chart version to satisfy the linter?

@rbjorklin rbjorklin force-pushed the deploy-resources-to-given-namespace branch from 744d097 to f389cd1 Compare February 13, 2025 18:09
@rbjorklin rbjorklin force-pushed the deploy-resources-to-given-namespace branch from f389cd1 to fe524fb Compare February 13, 2025 18:11
@rbjorklin
Copy link
Contributor Author

@rbjorklin could you increment the chart version to satisfy the linter?

Thanks for the ping @mboersma, fixed.

Copy link
Owner

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mboersma mboersma merged commit 1e3d14f into mboersma:main Feb 13, 2025
1 check passed
@rbjorklin rbjorklin deleted the deploy-resources-to-given-namespace branch February 13, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants