Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript access data attribute page improved #37805

Closed
wants to merge 6 commits into from

Conversation

StephenMuya
Copy link
Contributor

Description

I improved the Javascript access section to include an example.

Motivation

Additional details

Related issues and pull requests

Fixes: #37715

@StephenMuya StephenMuya requested a review from a team as a code owner January 25, 2025 19:17
@StephenMuya StephenMuya requested review from hamishwillee and removed request for a team January 25, 2025 19:17
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Jan 25, 2025
Copy link
Contributor

github-actions bot commented Jan 25, 2025

Preview URLs

(comment last updated: 2025-01-25 19:23:49)

StephenMuya and others added 5 commits January 25, 2025 22:20
…e_data_attributes/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e_data_attributes/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e_data_attributes/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e_data_attributes/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hamishwillee
Copy link
Collaborator

Thanks, but the page already has an example above:

<article
  id="electric-cars"
  data-columns="3"
  data-index-number="12314"
  data-parent="cars"></article>

If this were missing we still couldn't accept your example because that doesn't match the surrounding text - you'd have to make many more changes for that example to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the JavaScript section on the data attributes page
2 participants