-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript access data attribute page improved #37805
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenMuya
requested review from
hamishwillee
and removed request for
a team
January 25, 2025 19:17
files/en-us/learn_web_development/howto/solve_html_problems/use_data_attributes/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/solve_html_problems/use_data_attributes/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/solve_html_problems/use_data_attributes/index.md
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/solve_html_problems/use_data_attributes/index.md
Outdated
Show resolved
Hide resolved
Preview URLs (comment last updated: 2025-01-25 19:23:49) |
…e_data_attributes/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e_data_attributes/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e_data_attributes/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e_data_attributes/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Thanks, but the page already has an example above: <article
id="electric-cars"
data-columns="3"
data-index-number="12314"
data-parent="cars">
…
</article> If this were missing we still couldn't accept your example because that doesn't match the surrounding text - you'd have to make many more changes for that example to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I improved the Javascript access section to include an example.
Motivation
Additional details
Related issues and pull requests
Fixes: #37715