Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod ipred::neon: Move all fn *_neons to their own mod #582

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

kkysen
Copy link
Collaborator

@kkysen kkysen commented Nov 21, 2023

This is how things are done in C, and it simplifies the #[cfg]s a lot, too.

@kkysen kkysen requested a review from randomPoison November 21, 2023 22:29
@kkysen kkysen force-pushed the kkysen/mod-ipred-wrap_fn_ptr branch from 4a29b5d to 97662d8 Compare November 27, 2023 06:27
@kkysen kkysen force-pushed the kkysen/mod-ipred-neon branch from fa222c0 to f3feffc Compare November 27, 2023 06:27
@rinon
Copy link
Collaborator

rinon commented Nov 29, 2023

Would it make sense to move it into a separate file? I don't have a strong preference, and it's a minor thing, but not having to indent for the submodule might be nice.

@kkysen
Copy link
Collaborator Author

kkysen commented Nov 29, 2023

Would it make sense to move it into a separate file? I don't have a strong preference, and it's a minor thing, but not having to indent for the submodule might be nice.

Yeah it definitely could be. And it is in C. Should we just file an issue to do it later at some point?

@rinon
Copy link
Collaborator

rinon commented Nov 29, 2023

Is there any reason not to do it in this PR? You've already spent the time to split it into a separate module, so adding the file should be easy enough, right?

@kkysen
Copy link
Collaborator Author

kkysen commented Nov 29, 2023

Sure I can do it here, it's pretty simple.

@kkysen kkysen force-pushed the kkysen/mod-ipred-wrap_fn_ptr branch from 97662d8 to 0956cc2 Compare November 29, 2023 07:08
@kkysen
Copy link
Collaborator Author

kkysen commented Nov 29, 2023

Actually, in C, the fn *_dsp_init_{x86,arm}s are also in their own arch-specific file, but that's more unwieldy for us when fully cleaned up (see the final cleaned up version in mod filmgrain). And if I move mod neon to its own file, I wouldn't want to include a use super::*; in it like I have now, which just adds more noise. I don't think the benefit of not indenting everything extra is worth it, especially for modules smaller than ipred. So if it's okay with you, I'll keep things as is.

@kkysen kkysen force-pushed the kkysen/mod-ipred-neon branch from f3feffc to 3aa1661 Compare November 29, 2023 07:17
@kkysen kkysen force-pushed the kkysen/mod-ipred-wrap_fn_ptr branch from 0956cc2 to c1ee39a Compare November 30, 2023 07:00
This is how things are done in C, and it simplifies the `#[cfg]`s a lot, too.
@kkysen kkysen force-pushed the kkysen/mod-ipred-wrap_fn_ptr branch from c1ee39a to e885327 Compare November 30, 2023 07:01
@kkysen kkysen force-pushed the kkysen/mod-ipred-neon branch from 3aa1661 to 348b7db Compare November 30, 2023 07:04
Copy link
Collaborator

@rinon rinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a huge deal to me either way, so ok, let's keep it as an inline sub-module for now.

Base automatically changed from kkysen/mod-ipred-wrap_fn_ptr to main December 1, 2023 23:59
@kkysen kkysen merged commit 8f3f92b into main Dec 2, 2023
18 checks passed
@kkysen kkysen deleted the kkysen/mod-ipred-neon branch December 2, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants