-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod ipred::neon
: Move all fn *_neon
s to their own mod
#582
Conversation
4a29b5d
to
97662d8
Compare
fa222c0
to
f3feffc
Compare
Would it make sense to move it into a separate file? I don't have a strong preference, and it's a minor thing, but not having to indent for the submodule might be nice. |
Yeah it definitely could be. And it is in C. Should we just file an issue to do it later at some point? |
Is there any reason not to do it in this PR? You've already spent the time to split it into a separate module, so adding the file should be easy enough, right? |
Sure I can do it here, it's pretty simple. |
97662d8
to
0956cc2
Compare
Actually, in C, the |
f3feffc
to
3aa1661
Compare
0956cc2
to
c1ee39a
Compare
This is how things are done in C, and it simplifies the `#[cfg]`s a lot, too.
c1ee39a
to
e885327
Compare
3aa1661
to
348b7db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a huge deal to me either way, so ok, let's keep it as an inline sub-module for now.
This is how things are done in C, and it simplifies the
#[cfg]
s a lot, too.