backport from dav1d 1.2.0: picture: fix attaching props to delayed output pictures
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Metadata OBU appeared right before a Frame Header OBU with show_existing_picture = 1, it was not being attached to it but to the next assembled picture, which was in the following TU. Signed-off-by: James Almer <[email protected]>
kkysen
force-pushed
the
kkysen/backport-fn-rav1d_picture_copy_props
branch
from
bc09cb6 to
274c445
Compare
Co-authored-by: Khyber Sen <[email protected]>
kkysen
force-pushed
the
kkysen/backport-fn-rav1d_picture_copy_props
branch
from
274c445 to
a6c4e58
Compare
|
@randomPoison or @fbossen, could you take a quick look at this again, because I was initially getting a double free of |
randomPoison
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out how to push a rebased version to #518, so this is the same as #518 just rebased.