Backport from dav1d 1.3.0: add dav1d_version_api function
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Almer <[email protected]>
randomPoison
approved these changes
Feb 28, 2024
kkysen
reviewed
Feb 28, 2024
folkertdev
reviewed
Feb 28, 2024
kkysen
reviewed
Feb 29, 2024
src/lib.rs
Outdated
Comment on lines
122
to
127
| /** | ||
| * Get library API version. | ||
| * | ||
| * @return A value in the format 0x00XXYYZZ, where XX is the major version, | ||
| * YY the minor version, and ZZ the patch version. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Get library API version. | |
| * | |
| * @return A value in the format 0x00XXYYZZ, where XX is the major version, | |
| * YY the minor version, and ZZ the patch version. | |
| */ | |
| /// Get the `dav1d` library C API version. | |
| /// | |
| /// Return a value in the format `0x00XXYYZZ`, where `XX` is the major version, | |
| /// `YY` the minor version, and `ZZ` the patch version. |
kkysen
reviewed
Feb 29, 2024
kkysen
reviewed
Feb 29, 2024
There's no reason to be so strict by ensuring the tool only works with a library built from the exact same git snapshot, when the only thing that matters is API availability and ABI compatibility. Signed-off-by: James Almer <[email protected]>
fbossen
force-pushed
the
bp-1.3.0-0013
branch
from
590fbc7 to
d7bdbcf
Compare
kkysen
approved these changes
Feb 29, 2024
src/lib.rs
Outdated
| #[no_mangle] | ||
| #[cold] | ||
| pub extern "C" fn dav1d_version_api() -> c_uint { | ||
| <u32>::from_be_bytes([ |
There was a problem hiding this comment.
Do you need the <> around u32 here?
fbossen
force-pushed
the
bp-1.3.0-0013
branch
from
d7bdbcf to
a005f95
Compare
Update test program to check API version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.