backport from dav1d 1.2.0: picture: allow storing an array of Dav1dITUTT35 entries
#993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing in the spec prevents a Temporal Unit from having more than one Metadata OBU of type ITU-T T.35, so export them as an array instead of only exporting the last one we parse. This is backwards compatible with the previous implementation, as users unaware of this change can ignore the n_itut_t35 field and still access the first (or only) entry in the array as they have been doing until now.
…e generic and equivalent `mem::take`.
rinon
reviewed
Apr 23, 2024
kkysen
force-pushed
the
kkysen/backport-itutt35-vec
branch
from
9fbd679 to
d2ae68a
Compare
…g it an `Arc<Mutex<DRav1d<Vec<_>, Vec<_>>>>`. Due to the now shared access to the `itut_t35` `Vec` to push new ones during parsing, I added a zero-contention `Mutex` around it. This also adds a lot of explicit initialization that was previously just zero initialized, since the `Arc` is not all zeros. Co-authored-by: Frank Bossen <[email protected]>
…`Box<[_]>`s since the mutation only happens on `Rav1dContext::itut_t35`.
…re::itut_t35` needs it.
kkysen
force-pushed
the
kkysen/backport-itutt35-vec
branch
from
d2ae68a to
1c24cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #528 since it got closed because I deleted the target branch, which I guess happens when the PR branch is on a fork.