CI: Add eslint and fix a few things

.eslintignore

@@ -0,0 +1 @@
+src/pages/settings.svelte

.eslintrc.cjs

@@ -0,0 +1,45 @@
+module.exports = {
+	env: {
+		browser: true,
+		es2021: true,
+	},
+	extends: ["eslint:recommended", "plugin:svelte/recommended"],
+	overrides: [
+		{
+			env: {
+				node: true,
+			},
+			files: [".eslintrc.{js,cjs}"],
+			parserOptions: {
+				sourceType: "script",
+			},
+		},
+		{
+			files: ["*.svelte"],
+			parser: "svelte-eslint-parser",
+		},
+	],
+	parserOptions: {
+		ecmaVersion: "latest",
+		sourceType: "module",
+	},
+	rules: {
+		"svelte/no-at-html-tags": "off",
+		// blocks while (true) { ... } loops
+		"no-constant-condition": "off",
+		// regex stuff i dont understand, and catches <a />
+		"no-useless-escape": "off",
+		"no-unused-vars": [
+			"error",
+			{
+				argsIgnorePattern: "^_",
+				varsIgnorePattern: "^_",
+				caughtErrorsIgnorePattern: "^_",
+			},
+		],
+		// empty catch blocks are fine
+		"no-empty": "off",
+		// spaces for minor indentation, tabs for major indentation
+		"no-mixed-spaces-and-tabs": "off",
+	},
+};

.github/workflows/eslint.yaml

@@ -0,0 +1,41 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# ESLint is a tool for identifying and reporting on patterns
+# found in ECMAScript/JavaScript code.
+# More details at https://github.com/eslint/eslint
+# and https://eslint.org
+
+name: ESLint
+
+on:
+  push:
+    branches: [ "develop", "main" ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ "develop" ]
+  schedule:
+    - cron: '43 10 * * 2'
+
+jobs:
+  eslint:
+    name: Run eslint scanning
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      security-events: write
+      actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Install ESLint
+        run: |
+          npm install --group=dev
+          npm install eslint@8.10.0
+
+      - name: Run ESLint
+        run: npx eslint .
+          --config .eslintrc.cjs
+        continue-on-error: false

package.json

@@ -15,6 +15,8 @@
 		"@roxi/routify": "^2.18.12",
 		"@sveltejs/vite-plugin-svelte": "^3.1.1",
 		"@twemoji/api": "^15.1.0",
+		"eslint": "^8.56.0",
+		"eslint-plugin-svelte": "^2.35.1",
 		"markdown-it": "^14.1.0",
 		"prettier": "^3.3.3",
 		"prettier-plugin-svelte": "^3.2.5",

src/lib/PostList.svelte

@@ -191,8 +191,13 @@
 		if ($user.hide_blocked_users) {
 			// @ts-ignore
 			result = result.filter(
+				/*
+				* @type {import('./types.js').ListPost | import('./types.js').User} post
+				*/
 				post =>
+					// @ts-ignore
 					$relationships[post._id] !== 2 &&
+					// @ts-ignore
 					$relationships[post.u] !== 2
 			);
 		}
@@ -223,6 +228,7 @@
 		};
 		list.addItem(pendingPost);
 
+		// eslint-disable-next-line no-async-promise-executor
 		const postProm = new Promise(async (resolve, reject) => {
 			try {
 				const resp = await fetch(

src/lib/Sidebar.svelte

@@ -22,7 +22,6 @@
 	import profile from "../assets/profile.svg";
 	import settings from "../assets/settings.svg";
 	import logout from "../assets/logout.svg";
-	import changelog from "../assets/changelog.svg";
 	import info from "../assets/info.svg";
 
 	import {fade} from "svelte/transition";

src/lib/cloudlink.js

@@ -25,8 +25,6 @@
  * SOFTWARE.
  */
 
-import sleep from "./sleep.js";
-
 /**
  * A callback type used for packet events.
  *

src/lib/modals/moderation/KickAllUsers.svelte

@@ -7,15 +7,15 @@
 
 	import sleep from "../../sleep";
 
-	let loading, error;
+	let _loading, error;
 </script>
 
 <Modal on:close={modals.closeLastModal}>
 	<h2 slot="header">Kick All Users</h2>
 	<div slot="default">
 		<form
 			on:submit|preventDefault={async () => {
-				loading = true;
+				_loading = true;
 				try {
 					const resp = await fetch(`${apiUrl}admin/server/kick-all`, {
 						method: "POST",
@@ -29,7 +29,7 @@
 					modals.closeLastModal();
 				} catch (e) {
 					error = e;
-					loading = false;
+					_loading = false;
 				}
 			}}
 		>

src/lib/modals/moderation/ModerateUser.svelte

@@ -129,13 +129,10 @@
 	async function kick() {
 		kickStatus = "Kicking...";
 		try {
-			const resp = await fetch(
-				`${apiUrl}admin/users/${user._id}/kick`,
-				{
-					method: "POST",
-					headers: $authHeader,
-				}
-			);
+			const resp = await fetch(`${apiUrl}admin/users/${user._id}/kick`, {
+				method: "POST",
+				headers: $authHeader,
+			});
 			if (!resp.ok) {
 				throw new Error(
 					"Response code is not OK; code is " + resp.status

src/pages/settings.svelte

@@ -11,8 +11,6 @@
 		User,
 		Paintbrush,
 		Lock,
-		Smartphone,
-		Contact,
 		ShieldBan,
 		Flag,
 		Info,