Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Update authpswd.md to make it clear not to use authpswd #21

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

Finley224
Copy link
Contributor

I wrote a client using this to login, it should be more clear that this should not be used.

I wrote a client using this to login, it should be more clear that this should not be used.
@Finley224
Copy link
Contributor Author

let me fix this

@Finley224
Copy link
Contributor Author

"nodeModulesDir": "auto", is breaking it

@williamhorning
Copy link
Contributor

"nodeModulesDir": "auto", is breaking it

please update to the latest deno 2 rc using deno upgrade --rc

@Finley224
Copy link
Contributor Author

"nodeModulesDir": "auto", is breaking it

please update to the latest deno 2 rc using deno upgrade --rc

ok, let me give that a go

@Finley224
Copy link
Contributor Author

ok. if you re run the checks it should work now.

@Finley224
Copy link
Contributor Author

ok. if you re run the checks it should work now.

Yep, checks passed.

@williamhorning
Copy link
Contributor

alright, despite the checks passing, authpswd isn't completely replaced by the api route. in the majority of cases, you should use the api route and then pass the token to cloudlink using the token query parameter when connecting (with a url like wss://server.meower.org/?v=1&token=no, however, without that documented anywhere, just saying "don't use authpswd" is bad.

@Finley224
Copy link
Contributor Author

alright, despite the checks passing, authpswd isn't completely replaced by the api route. in the majority of cases, you should use the api route and then pass the token to cloudlink using the token query parameter when connecting (with a url like wss://server.meower.org/?v=1&token=no, however, without that documented anywhere, just saying "don't use authpswd" is bad.

ok, is there a way It could be worded better?

@Finley224
Copy link
Contributor Author

Finley224 commented Sep 29, 2024

@williamhorning what about adding a note like, Instead of using authpswd, get a token using the REST API then connect to the web socket with your token "wss://server.meower.org/?v=1&token={your token from api}".

@williamhorning
Copy link
Contributor

yes, that'd work

@Finley224
Copy link
Contributor Author

ok, let me add that to the pull request

@Finley224
Copy link
Contributor Author

Ok, I updated it based on your feedback @williamhorning.

Copy link
Contributor

@williamhorning williamhorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove package-lock file

@Finley224
Copy link
Contributor Author

@williamhorning done

@williamhorning williamhorning merged commit 38a3038 into meower-media:main Sep 30, 2024
2 checks passed
@Finley224 Finley224 deleted the patch-1 branch September 30, 2024 05:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants