Fix TypeScript types to support node16 and bundler moduleResolution modes
#634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the TypeScript types for this module only support the `node10` TypeScript module resolution mode. Now, `node10`, `node16` (ESM only), and `bundler` all work, according to https://arethetypeswrong.github.io/ Fixes: mermaid-js#628 Fixes: mermaid-js#633 Co-authored-by: Andrew Shaw Care <[email protected]>
|
All good with me, thanks for doing this! 👍 |
|
@aloisklink Can this be merged? There is a new mermaid release and I would like your PR to be included into the next mermaid-cli release? Thank you 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Currently, the TypeScript types for this module only support the
node10TypeScript module resolution mode.Now,
node10,node16(ESM only), andbundlerall work, according to https://arethetypeswrong.github.io/, see https://www.typescriptlang.org/docs/handbook/modules/theory.html#module-resolutionResolves #628
Resolves #633
📏 Design Decisions
@andrewshawcare, I've listed you as a co-author for this commit since the content is from your recommended patch in #633! Let me know if you're not comfortable with this, or if you'd prefer to make your own PR for this contribution!
📋 Tasks
Make sure you
📖 have read the contribution guidelines
💻 have added unit/e2e tests (if appropriate)
yarn packand checking the contents with https://arethetypeswrong.github.io/:🔖 targeted
masterbranch