fix: bump peerDependencies for Puppeteer v24
#836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is deprecated and will be removed in Puppeteer 24.
We now officially support Puppeteer v23 and v24.
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 23.9.0 to 24.0.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@puppeteer-v23.9.0...puppeteer-v24.0.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Bump the supported version of
puppeteerin ourpeerDepedenciesto support both Puppeteer v23 and v24.Resolves #831
📏 Design Decisions
The main breaking change that affected us was removing a deprecated type, but that only affects internal code, so it's not breaking to any users of
@mermaid-js/mermaid-cli.📋 Tasks
Make sure you
devDependenciesto target v24, so we are testing using that version!masterbranch