Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate instructions in "Install locally" section #850

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Remove duplicate instructions in "Install locally" section #850

merged 1 commit into from
Jan 29, 2025

Conversation

kukimik
Copy link
Contributor

@kukimik kukimik commented Jan 28, 2025

📑 Summary

Remove duplicate installation instructions. They were probably left after moving from yarn to npm.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted master branch

aloisklink
aloisklink approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Awesome work on catching this (it might be my fault since I was the one that converted this repo to npm 😅)

@aloisklink aloisklink added the documentation Improvements or additions to documentation label Jan 29, 2025
@aloisklink aloisklink merged commit 1df2c8f into mermaid-js:master Jan 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloisklink aloisklink aloisklink approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kukimik @aloisklink