Streamlining and enhancing diagram rendering across various diagram types #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: (462 commits) Update packages/mermaid/src/diagrams/sequence/parser/sequenceDiagram.jison fix: Simplify actor type of activeStart and activeEnd chore(deps): update all patch dependencies chore: Fix typo chore(deps): update all patch dependencies chore: remove repetitive words Update stateDiagram.md Update stateDiagram.md fix: simply from and to in message to string type docs: Add quadrant point styling feat: Change precedence of styling chore(deps): update all minor dependencies chore(deps): update all patch dependencies fix: eslint ignore, type definition chore(deps): update all patch dependencies fix: Remove `ImperativeState` type restriction. 📝🐛 fix schema link update latest news section Changes to rendering/gitGraph.spec.js - Added additional rendering test functionality for recognizing 'switch' as an alias to 'checkout'. 1. Changes to gitGraph.jison - Updated the regex to allow either 'checkout' or 'switch' 2. Changes to gitGraphParser.spec.js - Additional test coverage added for the changes made to the parser. 3. Changes to gitGraphParserV2.spec.js - Additional test coverafe added for the changes made to the parser. 4. Changes to gitgraph.md - Updated documentation to let users know that checkout/switch can be used interchangeably. ...
…aid-js/mermaid into 5237-unified-layout-common-renderer
…com/mermaid-js/mermaid into 5237-unified-layout-common-renderer * '5237-unified-layout-common-renderer' of https://github.com/mermaid-js/mermaid: #5237 Theme support for stateStart, stateEnd, choice and fork/join #5237 Improved Edge Handling #5237 pass css node style like bgColor, borderColor, borderWeight for roughjs
…aid-js/mermaid into 5237-unified-layout-common-renderer
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/mermaid/src/rendering-util/rendering-elements/createLabel.js
Dismissed
Show dismissed
Hide dismissed
4 tasks
|
@sidharthv96 This PR unifies rendering, but data4Layout still only contains the most basic information. As mentioned in #6095, the hope is to add layout information changes without imposing additional burdens on users who do not need this capability. I fully agree with this. Would it be a good idea to add a parameter in the db.getData function to indicate whether to additionally return graphData? I am very much looking forward to this capability and am happy to provide any assistance. Please let me know how I can help. Thank you very much! Looking forward to your reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
There is noticeable duplication in functionality among different diagram types. Several graph-based diagrams share common features in rendering, but these are implemented separately in each diagram type.
This PR introduces a Unified Layout Engine: Implement a singular layout engine for all graph-based diagrams.
Benefits:
Resolves #5237
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch