Partially revert GH-280 #343
Conversation
This reverts commits: - 4a4b54b - ba2743e - 26ab3e4 - 8661c22 Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
There was a problem hiding this comment.
This is the wrong solution to an invalid bug. The meson.build used to demonstrate the bug is invalid. It is not possible to use absolute paths as installation directories in meson.build and have them mapped to wheel paths, either by Meson or by meson-python.
If there is anything to improve is the error message. I thought that it was clear that using absolute installation paths to build wheel was not going to work, and I assumed that any instance of absolute paths in the installation data was a bug in Meson. However, this is not the case.
| @@ -400,7 +400,7 @@ def _warn_unsure_platlib(self, origin: pathlib.Path, destination: pathlib.Path) | |||
| """ | |||
| # {moduledir_shared} is currently handled in heuristics due to a Meson bug, | |||
| # but we know that files that go there are supposed to go to platlib. | |||
| if self._is_native(origin): | |||
| if origin.is_fifo() and self._is_native(origin): | |||
There was a problem hiding this comment.
If anything, this should be origin.is_file()
There was a problem hiding this comment.
Yes, sorry, wrong autocomplete.
|
|
||
|
|
||
| @pytest.mark.filterwarnings("ignore:::mesonpy") | ||
| def test_install_subdir_python_path(wheel_install_subdir_python_path): |
There was a problem hiding this comment.
You forgot to commit the test package. However, the test would be bogus, see my reply to #341
See my comment in #344 (comment). I am not gonna budge regarding this, unfortunately. This is something completely reasonable for users to do. |
Well, for many doing |
That's a limitation of meson-python though, that we cannot fix. Actually, we couldn't we fix it via the native file?
I mostly agree. Per #344 (comment), I don't think users should be doing this, so I am closing this PR. Thanks for pointing this out! |
This reverts commits:
Fixes #341