-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Friends feed #3161
base: master
Are you sure you want to change the base?
Friends feed #3161
Conversation
+ remove listens from regular user feed, as was always intended
Allows for closer types if we know what type of listens we are expecting
Moved the followers/following and similar users to the FriendsFeed instead
Doesn't quite look right when it is very wide, the event action buttons are too far away from the event content
Bright orange is probably not ideal for these buttons
…ng_order test We don't send listen events anymore, adjusted the test accordingly
@Aerozol Hello! I would very much like your feedback on this, specifically about wording. |
Oh, interesting. I didn't realise this was the plan so I'm struggling to shift gears a bit - I was definitely imagining "feed" as a bit of a one-stop shop for information, including follows. That said, not just a list of random/latest listens, more like "X user has been binging this release/track", or "a bunch of your follows have been listening to this release/track" etc. In that instance it makes sense to have a new tab that is literally just a friends feed. It could also be a fun one to press play on! I also imagined the feed could eventually be a good landing page (in line with social media/other sites that users will be used to), but we'd have to start adding some good stuff. I also can't think of anything to put into the feed sidebar, and I'm hesitant to put something in just to fill space. I suppose, if you are open to creating new items, the feed would now be largely playlist-related, so some shortcuts or preview regarding playlists could fit. That and recommended tracks... maybe a list of latest 10 recommended tracks. This could be annoying without a way to dismiss them, though. Let me know if you want me to do some more brainstorming or mocking-up. I would probably prefer new feed items to be added first though, tbh. |
Regarding the naming, I've gone back and forth a bit, but I probably would use "My follows". It is a bit unwieldy, but I think the same can be said for where we use "follow" elsewhere, except for on the actual "follow" button. I think we either change it in a few places or embrace our special terminology :) |
+ some renaming to "My Network" and removing mentions of "friends", we don't really use this vocabulary
The PR is currently deployed on https://test.listenbrainz.org/feed/follows I did a bit more brainstorming, and added another little slice of feature: Here's what I have so far:
|
|
+ stronger types
GENIUS. Especially with the similar uses feed. A really useful page that feels like it always belonged. No notes. I lie, I always have notes ahaha. But this is just musings, it's good to go as-is imo!
|
a301ebe
to
448a08a
Compare
Wasn't happy with the placement of the refresh/ play all buttons, decided to center both with a small gap
448a08a
to
87e3be5
Compare
OK, that's all done, thanks for the feedback ! I also thought instantly it will be a useful page, when I set it up and deployed live. |needs a way to filter by username, I think, but that's for another day. |
@anshg1214 Ready to review :) |
When we first added the feed page and functionality, we were worried about the feed looking very empty (the idea at the tiem was to make the feed the landing page).
As a stopgap measure, we added the most recent listens from followed users as filler, with the aim to remove it "soon™".
As a negative consequence, it makes the feed page loads much slower than it needs to be.
Now, years later and very late, it is finally time to remove them.
One extra push for it is having implemented infinite queries from react-query (in #2844), which make the inserted listens have even less sense (the listens loaded at first and the ones loaded later are not from similar times).
The solution I always envisioned was to have a separate page where I can see all listens (most recent first) from all the users I follow.
And here it is:
Open to feedbakc regarding the naming of this new page, as we don't use the word "friends" elsewhere in the website AFAIK.
"My follows" just didn't have the same ring to it.
I moved the follower/following and similar users section out of the regular feed, IMO it makes more sense to have it in this new "My friends" tab: