Add Sync bound for set_global_recorder #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I spend some time thinking, if the Send bound is also needed. But seems not: https://github.com/metrics-rs/metrics/blob/main/metrics/src/recorder/cell.rs#L44 global recorder is leaked via Box::leak and its destructor won't be called |
global recorder is shared between threads and must be sync closes metrics-rs#511
Nekrolm
commented
Sep 6, 2024
| @@ -55,7 +55,7 @@ pub struct RecoverableRecorder<R> { | |||
| handle: Arc<R>, | |||
| } | |||
|
|
|||
| impl<R: Recorder + 'static> RecoverableRecorder<R> { | |||
| impl<R: Recorder + Sync + Send + 'static> RecoverableRecorder<R> { | |||
There was a problem hiding this comment.
Send enforced here by Arc
tobz
approved these changes
Sep 14, 2024
tobz
added
C-core
|
Released as part of Thanks again for your contribution! |
tobz
removed
the
S-awaiting-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global recorder is shared between threads and must be sync
closes #511