improvement: make extend sync

michaelfeil · Apr 15, 2024 · ae95434 · ae95434
1 parent 93c27a5
commit ae95434
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/libs/infinity_emb/infinity_emb/inference/batch_handler.py b/libs/infinity_emb/infinity_emb/inference/batch_handler.py
@@ -215,7 +215,7 @@ async def _schedule(
                 item=inner,
             )
             new_prioqueue.append(item)
-        await self._queue_prio.extend(new_prioqueue)
+        self._queue_prio.extend(new_prioqueue)
 
         result = await asyncio.gather(
             *[self._result_store.wait_for_response(item.item) for item in new_prioqueue]

diff --git a/libs/infinity_emb/infinity_emb/inference/queue.py b/libs/infinity_emb/infinity_emb/inference/queue.py
@@ -21,8 +21,9 @@ def __init__(self) -> None:
     def __len__(self):
         return len(self._queue)
 
-    async def extend(self, items: list[PrioritizedQueueItem]):
+    def extend(self, items: list[PrioritizedQueueItem]):
         with self._lock_queue_event:
+            # TODO: _lock event might be conjesting the main thread.
             self._queue.extend(items)
         self._sync_event.set()