Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EngineArray Multi-Model [1/3] #200

Merged
merged 8 commits into from
Apr 13, 2024
Merged

Add EngineArray Multi-Model [1/3] #200

merged 8 commits into from
Apr 13, 2024

Conversation

michaelfeil
Copy link
Owner

@michaelfeil michaelfeil commented Apr 13, 2024

  • This feature is a work in progress to introduce a new concept: EngineArray
  • this enables usage of multiple engines at the same time / multi-mdoel deployment

Closes #13
#119

As a follow-up, need to make sure to launch multiple models via the CLI. This requires some refactoring of the cli. This is not part of this PR.

@michaelfeil michaelfeil marked this pull request as draft April 13, 2024 06:08
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 88.52459% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 73.60%. Comparing base (59a13c0) to head (6abebe1).
Report is 4 commits behind head on main.

Files Patch % Lines
libs/infinity_emb/infinity_emb/engine.py 87.87% 4 Missing ⚠️
libs/infinity_emb/infinity_emb/infinity_server.py 86.36% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   73.49%   73.60%   +0.11%     
==========================================
  Files          32       32              
  Lines        1811     1849      +38     
==========================================
+ Hits         1331     1361      +30     
- Misses        480      488       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil marked this pull request as ready for review April 13, 2024 08:10
@michaelfeil michaelfeil merged commit 8934ad2 into main Apr 13, 2024
14 checks passed
@michaelfeil michaelfeil deleted the engine_array branch April 13, 2024 20:08
@michaelfeil michaelfeil changed the title [WIP] Add EngineArray Add EngineArray Multi-Model [1/3] Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multimodel inference
2 participants