Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verbose parameter when initializing ModelWorker #516

Merged

Conversation

aRyBernAlTEglOTRO
Copy link
Contributor

Related Issue

#515

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added tests to cover my changes.
  • I have updated the documentation (docs folder) accordingly.

Additional Notes

Add any other context about the PR here.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes a bug where the verbose parameter was incorrectly passed as batch_delay instead of _verbose when initializing ModelWorker instances in the BatchHandler class.

  • Fixed incorrect parameter in BatchHandler.__init__() where ModelWorker was initialized with verbose=batch_delay instead of verbose=self._verbose
  • Change ensures proper debug logging behavior when verbose mode is enabled
  • Issue identified and reported in [BUG} Typo for vervose #515 as a typo that affected logging functionality

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.79%. Comparing base (ef4c424) to head (6d0784d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   79.90%   79.79%   -0.12%     
==========================================
  Files          43       43              
  Lines        3484     3484              
==========================================
- Hits         2784     2780       -4     
- Misses        700      704       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wirthual wirthual merged commit 2dbb178 into michaelfeil:main Jan 15, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants