Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.0.75 release #520

Merged
merged 1 commit into from
Jan 22, 2025
Merged

0.0.75 release #520

merged 1 commit into from
Jan 22, 2025

Conversation

michaelfeil
Copy link
Owner

Related Issue

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added tests to cover my changes.
  • I have updated the documentation (docs folder) accordingly.

Additional Notes

Add any other context about the PR here.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the CLI behavior and dependencies to support the nomic-ai/nomic-embed-text-v1.5 model while improving user experience.

  • Added einops as optional dependency in pyproject.toml to support nomic-ai/nomic-embed-text-v1.5 model
  • Modified CLI in libs/infinity_emb/infinity_emb/cli.py to automatically default to 'v2' command instead of showing error
  • Updated version from 0.0.74 to 0.0.75 in libs/infinity_emb/pyproject.toml
  • Improved error messaging in CLI to better guide users about version deprecation and upgrade path
  • Changed log level from critical to error for no-command case in CLI for better visibility

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +392 to +398
if len(sys.argv) == 1 or sys.argv[1] not in ["v1", "v2", "help", "--help"]:
logger.error(
"Error: No command given. Please use infinity with the `v2` command. "
f"This is deprecated since 0.0.32. You are on {infinity_emb.__version__}. "
"Usage: `infinity_emb v2 --model-id BAAI/bge-large-en-v1.5. "
"defaulting to `v2` since 0.0.75. Please pin your revision for future upgrades."
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: The error message has a missing closing quote after BAAI/bge-large-en-v1.5

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (2dbb178) to head (5e24a56).

Files with missing lines Patch % Lines
libs/infinity_emb/infinity_emb/cli.py 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   79.90%   79.86%   -0.05%     
==========================================
  Files          43       43              
  Lines        3484     3486       +2     
==========================================
  Hits         2784     2784              
- Misses        700      702       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 6a20ff3 into main Jan 22, 2025
36 checks passed
@michaelfeil michaelfeil deleted the 0.0.75-release branch January 22, 2025 22:22
"defaulting to `v2` since 0.0.75. Please pin your revision for future upgrades."
)

sys.argv.insert(1, "v2")
Copy link

@datavistics datavistics Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this take args from the env vars then?
I believe it will just like this:
https://huggingface.co/spaces/michaelfeil/infinity/blob/main/Dockerfile

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just run the docker file without the v2 command!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants