Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new st version #523

Merged
merged 1 commit into from
Jan 30, 2025
Merged

add new st version #523

merged 1 commit into from
Jan 30, 2025

Conversation

michaelfeil
Copy link
Owner

Related Issue

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added tests to cover my changes.
  • I have updated the documentation (docs folder) accordingly.

Additional Notes

Add any other context about the PR here.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates dependencies and configurations to support the nomic-ai/nomic-embed-text-v1.5 model, including version bumps and Docker environment changes.

  • Added einops as optional dependency and created new 'einops' extras group in /libs/infinity_emb/pyproject.toml
  • Updated sentence-transformers to version ^3.0.1 in /libs/infinity_emb/pyproject.toml
  • Updated Hugging Face transformers to commit 7547f55e5d across all Dockerfiles
  • Added .tool-versions file specifying Poetry 1.8.2 for consistent development environments
  • Bumped version from 0.0.75 to 0.0.76 in both infinity_emb and infinity_client packages

9 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

libs/infinity_emb/Dockerfile.jinja2 Show resolved Hide resolved
Comment on lines 53 to +54
# TODO: remove this line
RUN apt-get install --no-install-recommends -y git && poetry run python -m pip install git+https://github.com/huggingface/transformers.git@42865860ec6dc135972d9555753cb7ee17f51fb4 && rm -rf ~/.cache/ /tmp/*
RUN apt-get install --no-install-recommends -y git && poetry run python -m pip install git+https://github.com/huggingface/transformers.git@7547f55e5d93245c0a013b50df976924f2d9e8b0 && rm -rf ~/.cache/ /tmp/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: TODO comment indicates this is a temporary solution. Consider removing the direct git installation if possible and managing transformers version through pyproject.toml instead.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.80%. Comparing base (262ae3e) to head (8e770b0).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   79.86%   79.80%   -0.06%     
==========================================
  Files          43       43              
  Lines        3486     3486              
==========================================
- Hits         2784     2782       -2     
- Misses        702      704       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 9735ed5 into main Jan 30, 2025
36 checks passed
@michaelfeil michaelfeil deleted the poetry-version-update branch January 30, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants