Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update torch #525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update torch #525

wants to merge 1 commit into from

Conversation

michaelfeil
Copy link
Owner

Related Issue

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added tests to cover my changes.
  • I have updated the documentation (docs folder) accordingly.

Additional Notes

Add any other context about the PR here.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the PyTorch version requirement in libs/infinity_emb/pyproject.toml to support the nomic-ai/nomic-embed-text-v1.5 model.

  • Inconsistent PyTorch version requirements: main dependency pinned at >=2.2.1 while dev dependency updated to 2.6.0
  • Missing required einops dependency for nomic-ai/nomic-embed-text-v1.5 model support
  • Missing sentence-transformers version update to >2.4.0 needed for model compatibility
  • Documentation and test updates still pending according to PR checklist
  • Potential version conflicts could arise from mismatched PyTorch requirements

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base (9735ed5) to head (e3eb059).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (9735ed5) and HEAD (e3eb059). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (9735ed5) HEAD (e3eb059)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   79.86%   72.31%   -7.55%     
==========================================
  Files          43       43              
  Lines        3486     3486              
==========================================
- Hits         2784     2521     -263     
- Misses        702      965     +263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants