Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies and Net Targets #678

Merged
merged 3 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.52] - 2024-12-09
## Dependencies
Updates Dependencies

## .Net Targets
CLI now targets .NET 8.0 and .NET 9.0, .NET 6.0/7.0 targeting removed. DevSkim Library component retains .Net Standard 2.1 support.

## [1.0.51] - 2024-12-09
## Fix
Fix confidence filtering at rule level.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<AssemblyName>devskim</AssemblyName>
<StartupObject>Microsoft.DevSkim.CLI.Program</StartupObject>
<RuntimeIdentifiers>win-x64;linux-x64;osx-x64</RuntimeIdentifiers>
Expand Down Expand Up @@ -36,10 +36,13 @@

<ItemGroup>
<PackageReference Include="CommandLineParser" Version="2.9.1" />
<PackageReference Include="LibGit2Sharp" Version="0.29.0" />
<PackageReference Include="Microsoft.CST.ApplicationInspector.Logging" Version="1.9.19" />
<PackageReference Include="LibGit2Sharp" Version="0.31.0" />
<PackageReference Include="Microsoft.CST.ApplicationInspector.Logging" Version="1.9.32" />
<PackageReference Include="Microsoft.Extensions.CommandLineUtils" Version="1.1.1" />
<PackageReference Include="Sarif.Sdk" Version="4.5.3" />
<PackageReference Include="Sarif.Sdk" Version="4.5.4" />
<PackageReference Update="Nerdbank.GitVersioning">
<Version>3.7.115</Version>
</PackageReference>
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

<ItemGroup>
<PackageReference Include="OmniSharp.Extensions.LanguageServer" Version="0.19.9" />
<PackageReference Update="Nerdbank.GitVersioning">
<Version>3.7.115</Version>
</PackageReference>
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,22 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>DevSkim.LanguageServer</RootNamespace>
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
<TargetFramework>net8.0</TargetFramework>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<Authors>Microsoft</Authors>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="CommandLineParser" Version="2.9.1" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="9.0.1" />
<PackageReference Include="OmniSharp.Extensions.LanguageServer" Version="0.19.9" />
<PackageReference Include="Serilog.Extensions.Logging" Version="8.0.0" />
<PackageReference Include="Serilog.Sinks.Debug" Version="2.0.0" />
<PackageReference Include="Serilog.Sinks.File" Version="5.0.0" />
<PackageReference Include="Serilog.Extensions.Logging" Version="9.0.0" />
<PackageReference Include="Serilog.Sinks.Debug" Version="3.0.0" />
<PackageReference Include="Serilog.Sinks.File" Version="6.0.0" />
<PackageReference Update="Nerdbank.GitVersioning">
<Version>3.7.115</Version>
</PackageReference>
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="MSTest.TestAdapter" Version="3.2.2" />
<PackageReference Include="MSTest.TestFramework" Version="3.2.2" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="MSTest.TestAdapter" Version="3.7.3" />
<PackageReference Include="MSTest.TestFramework" Version="3.7.3" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.Common" Version="4.8.0" />
<PackageReference Include="Microsoft.CodeAnalysis.Common" Version="4.12.0" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,17 @@
</None>
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.12.0" />
<PackageReference Include="Microsoft.VisualStudio.LanguageServer.Client">
<Version>17.9.46</Version>
<Version>17.12.48</Version>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.LanguageServer.Protocol">
<Version>17.2.8</Version>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="17.9.37000" ExcludeAssets="runtime">
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="17.12.40392" ExcludeAssets="runtime">
<IncludeAssets>compile; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.9.3168">
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.12.2069">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
7 changes: 5 additions & 2 deletions DevSkim-DotNet/Microsoft.DevSkim/Microsoft.DevSkim.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.1;net6.0;net7.0;net8.0</TargetFrameworks>
<TargetFrameworks>netstandard2.1;net8.0;net9.0</TargetFrameworks>
<PackageId>Microsoft.CST.DevSkim</PackageId>
<PackageVersion>0.0.0</PackageVersion>
<PackageTags>Security Linter</PackageTags>
Expand All @@ -24,8 +24,11 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CST.ApplicationInspector.RulesEngine" Version="1.9.19" />
<PackageReference Include="Microsoft.CST.ApplicationInspector.RulesEngine" Version="1.9.32" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Update="Nerdbank.GitVersioning">
<Version>3.7.115</Version>
</PackageReference>
</ItemGroup>

<ItemGroup>
Expand Down
7 changes: 4 additions & 3 deletions DevSkim-VSCode-Plugin/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup>
<PackageReference Include="Nerdbank.GitVersioning">
<Version>3.6.133</Version>
<Version>3.7.115</Version>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions Pipelines/cli/devskim-cli-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ resources:
- repository: templates
type: git
name: SecurityEngineering/OSS-Tools-Pipeline-Templates
ref: refs/tags/v2.0.0
ref: refs/tags/v2.0.1
- repository: 1esPipelines
type: git
name: 1ESPipelineTemplates/1ESPipelineTemplates
ref: refs/tags/release

variables:
BuildConfiguration: 'Release'
DotnetVersion: '8.0.x'
DotnetVersion: '9.0.x'

extends:
template: v1/1ES.Official.PipelineTemplate.yml@1esPipelines
Expand All @@ -36,15 +36,15 @@ extends:
- template: dotnet-test-job.yml@templates
parameters:
jobName: 'dotnet_test_windows'
dotnetVersions: ['6.0.x','7.0.x','8.0.x']
dotnetVersions: ['8.0.x','9.0.x']
projectPath: 'DevSkim-DotNet/Microsoft.DevSkim.Tests/Microsoft.DevSkim.Tests.csproj'
poolName: MSSecurity-1ES-Build-Agents-Pool
poolImage: MSSecurity-1ES-Windows-2022
poolOs: windows
- template: dotnet-test-job.yml@templates
parameters:
jobName: 'dotnet_test_ubuntu'
dotnetVersions: ['6.0.x','7.0.x','8.0.x']
dotnetVersions: ['8.0.x','9.0.x']
poolName: MSSecurity-1ES-Build-Agents-Pool
poolImage: MSSecurity-1ES-Ubuntu-2204
poolOs: linux
Expand Down
8 changes: 4 additions & 4 deletions Pipelines/cli/devskim-cli-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ resources:
- repository: templates
type: git
name: Data/OSS-Tools-Pipeline-Templates
ref: refs/tags/v2.0.0
ref: refs/tags/v2.0.1
- repository: 1esPipelines
type: git
name: 1ESPipelineTemplates/1ESPipelineTemplates
ref: refs/tags/release

variables:
BuildConfiguration: 'Release'
DotnetVersion: '8.0.x'
DotnetVersion: '9.0.x'

extends:
template: v1/1ES.Official.PipelineTemplate.yml@1esPipelines
Expand All @@ -35,15 +35,15 @@ extends:
- template: dotnet-test-job.yml@templates
parameters:
jobName: 'dotnet_test_windows'
dotnetVersions: ['6.0.x','7.0.x','8.0.x']
dotnetVersions: ['8.0.x','9.0.x']
projectPath: 'DevSkim-DotNet/Microsoft.DevSkim.Tests/Microsoft.DevSkim.Tests.csproj'
poolName: MSSecurity-1ES-Build-Agents-Pool
poolImage: MSSecurity-1ES-Windows-2022
poolOs: windows
- template: dotnet-test-job.yml@templates
parameters:
jobName: 'dotnet_test_ubuntu'
dotnetVersions: ['6.0.x','7.0.x','8.0.x']
dotnetVersions: ['8.0.x','9.0.x']
poolName: MSSecurity-1ES-Build-Agents-Pool
poolImage: MSSecurity-1ES-Ubuntu-2204
poolOs: linux
Expand Down
9 changes: 3 additions & 6 deletions Pipelines/vs/devskim-visualstudio-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resources:
- repository: templates
type: git
name: SecurityEngineering/OSS-Tools-Pipeline-Templates
ref: refs/tags/v2.0.0
ref: refs/tags/v2.0.1
- repository: 1esPipelines
type: git
name: 1ESPipelineTemplates/1ESPipelineTemplates
Expand Down Expand Up @@ -46,14 +46,11 @@ extends:
extraArtifactLocation: 'extension'
preBuild:
- template: nbgv-set-version-steps.yml@templates
# Workaround: Using the .NET 8 SDK doesn't install the right version of MSBuild for .NET 8
# Using the .NET 7 SDK doesn't include the .NET 8 SDK so it can't build the project
# Install both for now until the right version of MSBuild is included with .NET 8
- task: UseDotNet@2
displayName: Install Dotnet 7 SDK
displayName: Install Dotnet 9 SDK
inputs:
packageType: 'sdk'
version: '7.0.x'
version: '9.0.x'
onEnd:
- task: PowerShell@2
displayName: Mkdir for Extension
Expand Down
9 changes: 3 additions & 6 deletions Pipelines/vs/devskim-visualstudio-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ resources:
- repository: templates
type: git
name: Data/OSS-Tools-Pipeline-Templates
ref: refs/tags/v2.0.0
ref: refs/tags/v2.0.1
- repository: 1esPipelines
type: git
name: 1ESPipelineTemplates/1ESPipelineTemplates
Expand Down Expand Up @@ -45,14 +45,11 @@ extends:
extraArtifactLocation: 'extension'
preBuild:
- template: nbgv-set-version-steps.yml@templates
# Workaround: Using the .NET 8 SDK doesn't install the right version of MSBuild for .NET 8
# Using the .NET 7 SDK doesn't include the .NET 8 SDK so it can't build the project
# Install both for now until the right version of MSBuild is included with .NET 8
- task: UseDotNet@2
displayName: Install Dotnet 7 SDK
displayName: Install Dotnet 9 SDK
inputs:
packageType: 'sdk'
version: '7.0.x'
version: '9.0.x'
onEnd:
- task: PowerShell@2
displayName: Mkdir for Extension
Expand Down
5 changes: 5 additions & 0 deletions Pipelines/vscode/devskim-vscode-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ extends:
inputs:
packageType: 'sdk'
version: '8.0.x'
- task: UseDotNet@2
displayName: Install Dotnet SDK
inputs:
packageType: 'sdk'
version: '9.0.x'
- task: Npm@1
displayName: Build VS Code Plugin
inputs:
Expand Down
7 changes: 6 additions & 1 deletion Pipelines/vscode/devskim-vscode-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ resources:
- repository: templates
type: git
name: Data/OSS-Tools-Pipeline-Templates
ref: refs/tags/v2.0.0
ref: refs/tags/v2.0.1
- repository: 1esPipelines
type: git
name: 1ESPipelineTemplates/1ESPipelineTemplates
Expand Down Expand Up @@ -42,6 +42,11 @@ extends:
inputs:
packageType: 'sdk'
version: '8.0.x'
- task: UseDotNet@2
displayName: Install Dotnet SDK
inputs:
packageType: 'sdk'
version: '9.0.x'
- task: Npm@1
displayName: Build VS Code Plugin
inputs:
Expand Down