Updated the executor function to provide support for plotly that fixes #36

[Alfred-Onuada]

This pull request adds support for the missing Plotly visualization library.

so the following code won't throw an error anymore
lida.visualize(summary=summary, goal=goals[3], textgen_config=textgen_config, library='plotly')

[Alfred-Onuada]

@microsoft-github-policy-service agree

[trojrobert]

@Alfred-Onuada
Please can you check the code, I am getting the error

[trojrobert]

@Alfred-Onuada I think the code works for some plot like scatter plot but not histogram

[Alfred-Onuada]

I will have a look now, thanks for mentioning

[trojrobert]

@Alfred-Onuada I was already looking into it so I was able to spot the error.

In your scaffold template, you need to add "fig.show()" before returning chart. Please add that

[Alfred-Onuada]

@trojrobert take a look again I pushed a new commit to make sure visualize for plotly returns the raster and chart, to prevent errors.

I also tested with histograms across 3 datasets and it worked fine, let me know if you face any errors.

[trojrobert]

It is still not working. I actually already have the code to solve this but I wanted you to also contribute.

[trojrobert]

Please show me a test

[Alfred-Onuada]

@trojrobert

Below is the cli test using pytest

[Alfred-Onuada]

what test command are you using?

[trojrobert]

@Alfred-Onuada You code has a new dependency, we need to add that to the requirements. What version of kaleido are you using?

[trojrobert]

@Alfred-Onuada I commented on this before. You need to add fig.show() to the template

[trojrobert]

@Alfred-Onuada Please check my comment on scaffold.py.

Please also test with multiple dataset

[Alfred-Onuada]

@trojrobert [email protected], I have also included the fig.show() in the template

[trojrobert]

@victordibia I think this PR should be done.

[victordibia]

Thanks @Alfred-Onuada and @trojrobert
I'll review this PR and merge soon!

-V.

[victordibia]

Thanks again all, this looks good! Merging!