Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a chart util for display ChartExecutorResponse #54

Merged
merged 4 commits into from
Oct 19, 2023
Merged

feat: add a chart util for display ChartExecutorResponse #54

merged 4 commits into from
Oct 19, 2023

Conversation

bx-h
Copy link
Contributor

@bx-h bx-h commented Oct 17, 2023

#52

@bx-h
Copy link
Contributor Author

bx-h commented Oct 17, 2023

@microsoft-github-policy-service agree

@victordibia
Copy link
Collaborator

Hi @bx-h ,

Thanks for this, it makes a bit of progress in addressing #52.
I was thinking of a much simpler solution ie. extending ChartExecutor response directly.
I pushed that change. Main approach

  • Add a savefig to ChartExecutor directly in datamodel.py. This avoids adding an new file to the codebase.
  • Does not add any additional dependencies e.g. cv2, . This makes the library ligther.

Finally, I think displaying the image should be implemented outside the library, as many applications may chose to visualization an image in different ways.

In terms of your PR, while change e428 covers a bit of it, I think extending the tests you added would be valuable here

@bx-h
Copy link
Contributor Author

bx-h commented Oct 18, 2023

Hi @victordibia ,
You're right! I've updated the test cases following your suggestion.

@victordibia victordibia merged commit f0caa61 into microsoft:main Oct 19, 2023
@bx-h bx-h deleted the chart-display branch January 8, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants