-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support images in table #284
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
This looks promising. A few requests. Can you break this into to PRs? One for testing the language, and the other for keeping in-line images. Can you use the pre-commit hook to format the files before commit. And can you add test cases for each update? Thanks again for the contribution! |
ec99832
to
95da5fd
Compare
Great to hear, I'll wait for these PRs to be merged. I'm using this package for a lot of things, it's great. Thanks! |
Pull Request Description
Summary
This PR enhances
_CustomMarkdownify
with a feature:td
,tr
,div
,p
, andspan
elements.Changes
options
to includekeep_inline_images_in
.Thank you for reviewing!