Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): fix run command crashing without build #3545

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix(cli): fix run command crashing without build #3545

merged 1 commit into from
Mar 6, 2025

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Mar 5, 2025

Description

Fix run command crashing if the build command was not invoked first

Test plan

  1. Clone chore: migrate build/run commands to @rnx-kit/cli react-native-test-app#2266
  2. Run yarn android from the examples folder

@github-actions github-actions bot added the feature: cli This is related to CLI label Mar 5, 2025
@tido64 tido64 merged commit d58075f into main Mar 6, 2025
12 checks passed
@tido64 tido64 deleted the tido/cli/fix-run-command branch March 6, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@JasonVMo JasonVMo JasonVMo approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms acoates-ms is a code owner

Assignees
No one assigned
Labels
feature: cli This is related to CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tido64 @Saadnajmi @JasonVMo