Adds make type-check (#269)

To run python type checking at the command line for dev-time and PR
validation-time.

Switches from "basic" to "standard" validation for Pylance in vscode, to
match the default `pyright` level

Additionally, fixes some type errors found in various projects.

.github/workflows/assistants-explorer-assistant.yml

@@ -24,8 +24,24 @@ defaults:
     working-directory: assistants/explorer-assistant
 
 jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v3
+
+      - name: Set up Python 3.11
+        run: uv python install 3.11
+
+      - name: test
+        run: |
+          make test
+
   build:
     runs-on: ubuntu-latest
+    needs: test
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/assistants-guided-conversation-assistant.yml

@@ -24,8 +24,24 @@ defaults:
     working-directory: assistants/guided-conversation-assistant
 
 jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v3
+
+      - name: Set up Python 3.11
+        run: uv python install 3.11
+
+      - name: test
+        run: |
+          make test
+
   build:
     runs-on: ubuntu-latest
+    needs: test
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/assistants-prospector-assistant.yml

@@ -24,8 +24,24 @@ defaults:
     working-directory: assistants/prospector-assistant
 
 jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v3
+
+      - name: Set up Python 3.11
+        run: uv python install 3.11
+
+      - name: test
+        run: |
+          make test
+
   build:
     runs-on: ubuntu-latest
+    needs: test
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/assistants-skill-assistant.yml

@@ -24,8 +24,24 @@ defaults:
     working-directory: assistants/skill-assistant
 
 jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v3
+
+      - name: Set up Python 3.11
+        run: uv python install 3.11
+
+      - name: test
+        run: |
+          make test
+
   build:
     runs-on: ubuntu-latest
+    needs: test
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/workbench-service.yml

@@ -42,8 +42,8 @@ jobs:
       - name: Set up Python ${{ matrix.python-version }}
         run: uv python install ${{ matrix.python-version }}
 
-      - name: pytest
-        run: uv run pytest --dbtype=${{ matrix.dbtype }}
+      - name: test
+        run: make test PYTEST_ARGS="--dbtype=${{ matrix.dbtype }}"
 
   build:
     runs-on: ubuntu-latest

.vscode/settings.json

@@ -25,7 +25,7 @@
   ],
   "python.analysis.fixAll": ["source.unusedImports"],
   "python.analysis.inlayHints.functionReturnTypes": true,
-  "python.analysis.typeCheckingMode": "basic",
+  "python.analysis.typeCheckingMode": "standard",
   "python.defaultInterpreterPath": "${workspaceFolder}/workbench-service/.venv",
   "python.languageServer": "Pylance",
   "python.testing.pytestEnabled": true,

assistants/explorer-assistant/.vscode/settings.json

@@ -23,7 +23,7 @@
   "python.analysis.diagnosticMode": "workspace",
   "python.analysis.fixAll": ["source.unusedImports"],
   "python.analysis.inlayHints.functionReturnTypes": true,
-  "python.analysis.typeCheckingMode": "basic",
+  "python.analysis.typeCheckingMode": "standard",
   "python.defaultInterpreterPath": "${workspaceFolder}/.venv",
   "[python]": {
     "editor.defaultFormatter": "charliermarsh.ruff",

assistants/explorer-assistant/assistant/config.py

@@ -151,7 +151,7 @@ class AssistantConfigModel(BaseModel):
         " code snippets, and other types of content. If you wrap your response in triple backticks, you can specify the"
         " language for syntax highlighting. For example, ```python print('Hello, World!')``` will produce a code"
         " snippet in Python. Mermaid markdown is supported if you wrap the content in triple backticks and specify"
-        " 'mermaid' as the language. For example, ```mermaid graph TD; A-->B;``` will render a flowchart for the"
+        ' \'mermaid\' as the language. For example, ```mermaid graph TD; A["A"]-->B["B"];``` will render a flowchart for the'
         " user.ABC markdown is supported if you wrap the content in triple backticks and specify 'abc' as the"
         " language.For example, ```abc C4 G4 A4 F4 E4 G4``` will render a music score and an inline player with a link"
         " to download the midi file."

assistants/explorer-assistant/pyproject.toml

@@ -30,3 +30,8 @@ assistant-extensions = { path = "../../libraries/python/assistant-extensions", e
 [build-system]
 requires = ["hatchling"]
 build-backend = "hatchling.build"
+
+[dependency-groups]
+dev = [
+    "pyright>=1.1.389",
+]

assistants/guided-conversation-assistant/.vscode/settings.json

@@ -28,7 +28,7 @@
   ],
   "python.analysis.fixAll": ["source.unusedImports"],
   "python.analysis.inlayHints.functionReturnTypes": true,
-  "python.analysis.typeCheckingMode": "basic",
+  "python.analysis.typeCheckingMode": "standard",
   "python.defaultInterpreterPath": "${workspaceFolder}/.venv",
   "[python]": {
     "editor.defaultFormatter": "charliermarsh.ruff",

assistants/guided-conversation-assistant/pyproject.toml

@@ -33,5 +33,10 @@ openai-client = { path = "../../libraries/python/openai-client", editable = true
 requires = ["hatchling"]
 build-backend = "hatchling.build"
 
+[dependency-groups]
+dev = [
+    "pyright>=1.1.389",
+]
+
 [tool.pyright]
 exclude = ["venv", ".venv"]