Implement consistent registry access for vcpkg command accessing ports #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ras0219-msft I take your emoji as a good sign, I'll keep this work going into the same direction ! |
theblackunknown
force-pushed
the
consistent-registry-access
branch
from
206f011 to
5ffa68c
Compare
theblackunknown
force-pushed
the
consistent-registry-access
branch
from
5ffa68c to
0da3797
Compare
theblackunknown
force-pushed
the
consistent-registry-access
branch
from
0da3797 to
69bb1f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the behavior to consistently access a port and its versions for vcpkg command discussed in microsoft/vcpkg#18967
I consider this PR as a draft for now as I have only testing code changes on
x-add-versionand a new commandformat-portlike it was suggested in the initial PR, and I am looking for feedbacks whether this is going into the right direction or not.Although I have implement this wanted behavior as a separate struct
CommandRegistryPathscontainingvcpkg::Path, I feel like this would be more coherent if implemented directly as additional method onvcpkg::RegistryImplementationandvcpkg::RegistryEntry.However as this is my first PR I lack context and experience with the code base to decide this is a good direction or not.
NOTE: This is only a partial implementation over the initial spec (e.g. read-only registry not implemented).