Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom registries in commands #93

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Support custom registries in commands #93

wants to merge 10 commits into from

Conversation

autoantwort
Copy link
Contributor

@autoantwort autoantwort commented Jun 14, 2021 •
edited
Loading

Same as #90 but rebased

@autoantwort autoantwort force-pushed the support-custom-registries branch from 9cda6a2 to 295e3e7 Compare June 14, 2021 20:50
@autoantwort autoantwort mentioned this pull request Jun 15, 2021
Open
strega-nil-ms
strega-nil-ms suggested changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see these changed first, then we can look at the resulting code and see what it looks like

@autoantwort autoantwort mentioned this pull request Jul 2, 2021
Merged
@strega-nil-ms strega-nil-ms added the depends:different-pr This PR depends on a different PR which has been filed label Jul 2, 2021
@strega-nil-ms
Copy link
Contributor

Depends on #105

@autoantwort autoantwort force-pushed the support-custom-registries branch from db751da to 126641c Compare July 2, 2021 18:33
@autoantwort autoantwort force-pushed the support-custom-registries branch from 126641c to d3d21c6 Compare July 2, 2021 18:44
strega-nil-ms
strega-nil-ms reviewed Jul 2, 2021
View reviewed changes
@autoantwort autoantwort force-pushed the support-custom-registries branch from 2b0efc6 to c02a947 Compare July 2, 2021 20:56
@strega-nil-ms strega-nil-ms removed the depends:different-pr This PR depends on a different PR which has been filed label Jul 6, 2021
@BillyONeal BillyONeal mentioned this pull request Jul 15, 2021
Open
@theblackunknown
Copy link

As a maintainer of a custom registry this PR definitely looks interesting !
Is there anything I can do to help move it forward ?

@autoantwort
Copy link
Contributor Author

First microsoft/vcpkg#18967 must be "resolved" and then it can be implemented

@theblackunknown
Copy link

I understand, I'll follow the discussion there to keep an eye on this then.

@autoantwort autoantwort mentioned this pull request Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms requested changes

Assignees
No one assigned
Labels
depends:registry-editing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autoantwort @strega-nil-ms @theblackunknown @BillyONeal