Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-applocal Phase 2 -- extensible interface for ports #974

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ras0219-msft
Copy link
Contributor

Still in progress, however the draft interface is to create a file named <dll filename>.plugin.json with the plugin metadata. For example, bin/Qt5Core.dll.plugin.json might be

{
  "patterns": {
    "bin/Qt5Gui.dll": "Qt5Gui.dll",
    "bin/plugins/*.dll": "plugins/",
    "share/openni2/config/**": "config/"
  }
}

The three patterns are:

  1. Exact File (no wildcards) -- This can do renaming.
  2. Prefix+suffix non-recursive file match (/A*B, A & B are optional) -- Destination needs to be a directory. Case-sensitive (?).
  3. Full recursive deployment -- No filters possible, deploys the entire subtree. Destination should be a directory.

@Neumann-A
Copy link
Contributor

I missing the condition of deployment here. What is the trigger which would lead to a deployment of a plugin?

@ras0219-msft
Copy link
Contributor Author

What is the trigger which would lead to a deployment of a plugin?

The trigger doesn't change from today; it would be having a reference to Qt5Core.dll in your DLL imports.

Specifically, if we deploy bin/Qt5Core.dll, we will follow the plugin deployments listed in bin/Qt5Core.dll.plugin.json.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 4, 2023

Please edit the initial example to resolve the confusion about Qt5Core vs. Qt5Gui.
And please give an indication about handling:

  • plugins in otherwise static ports
  • non-Windows platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants