[vcpkg scripts] Fix command prompt error #43399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwang118
added
info:internal
jimwang118
added
category:vcpkg-bug
|
The right fix would be the addition of a field that specifies the minimum required version and the version that is downloaded. |
BillyONeal
requested changes
Jan 22, 2025
| @@ -70,7 +70,7 @@ | |||
| { | |||
| "name": "git", | |||
| "os": "windows", | |||
| "version": "2.7.4", | |||
| "version": "2.43.0", | |||
There was a problem hiding this comment.
This might break Windows customers who have older than 2.43 installed because it forces an extra download on them. We should only do that if there is something vcpkg explicitly needs from a later version.
|
Duplicate of microsoft/vcpkg-tool#1583. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43368
Changes comply with the maintainer guide.SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory.The version database is fixed by rerunning./vcpkg x-add-version --alland committing the result.Only one version is added to each modified port's versions file.Verify that the command output is correct.