Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastdds] Fix missing fast-discovery-serverd-1.0.1 #43931

Merged
merged 6 commits into from
Feb 25, 2025
Merged

[fastdds] Fix missing fast-discovery-serverd-1.0.1 #43931

merged 6 commits into from
Feb 25, 2025
+16 −1

Conversation

jimwang118
Copy link
Contributor

Fixes #43654

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test passed with x64-linux and x64-windows triplets.

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Feb 20, 2025
@jimwang118 jimwang118 changed the title [fastdds] Fix link error [fastdds] Fix missing fast-discovery-serverd-1.0.1 Feb 20, 2025
@jimwang118 jimwang118 marked this pull request as ready for review February 24, 2025 06:30
WangWeiLin-MV
WangWeiLin-MV approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port installation tests pass with the following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Feb 25, 2025
@JavierMatosD JavierMatosD merged commit efe4ed4 into microsoft:master Feb 25, 2025
18 checks passed
pull bot pushed a commit to adamtajti/vcpkg that referenced this pull request Feb 25, 2025
@jimwang118 @pull
[fastdds] Fix missing fast-discovery-serverd-1.0.1 (microsoft#43931)
ea3474b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fastdds] build failure - file does not exist - fast-discovery-serverd-1.0.1
3 participants
@jimwang118 @WangWeiLin-MV @JavierMatosD