Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usearch] add features #43950

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

toge
Copy link
Contributor

@toge toge commented Feb 21, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

usearch provides several options for external dependencies.

@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 21, 2025
@jimwang118
Copy link
Contributor

Usage test failed.

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error		CMake Error at F:\testspace\tuse\CMakeLists.txt:16 (find_package):
  Could not find a package configuration file provided by "usearch" with any
  of the following names:

    usearchConfig.cmake
    usearch-config.cmake

  Add the installation prefix of "usearch" to CMAKE_PREFIX_PATH or set
  "usearch_DIR" to a directory containing one of the above files.  If
  "usearch" provides a separate development package or SDK, be sure it has
  been installed.	tuse	F:\testspace\tuse\CMakeLists.txt	16	

@jimwang118 jimwang118 marked this pull request as draft February 24, 2025 06:28
@toge
Copy link
Contributor Author

toge commented Feb 24, 2025

@jimwang118
Would you give me more information?
I don't know how to improve it because I successed to find usearch package in my local environment.

-- Running vcpkg install - done
-- The CXX compiler identification is GNU 14.2.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found usearch: /tmp/test-usearch/build/vcpkg_installed/x64-linux/share/usearch/usearchConfig.cmake (found version "2.17.2")
-- Configuring done (48.7s)
-- Generating done (0.0s)

CMakeLists.txt is following.

cmake_minimum_required(VERSION 3.15)
project(test-usearch LANGUAGES CXX)

find_package(usearch REQUIRED CONFIG)

add_executable(test test.cpp)
target_link_libraries(test PRIVATE
    usearch::usearch
)

@jimwang118 jimwang118 marked this pull request as ready for review February 25, 2025 01:45
@jimwang118
Copy link
Contributor

Usage test passed with x64-windows triplet.

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Feb 25, 2025
Copy link
Contributor

@JavierMatosD JavierMatosD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If usearch can be used without the fp16 feature enabled then it should be removed from the default-features list

]
],
"default-features": [
"fp16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is usearch useful without the fp16 feature enabled?

@JavierMatosD JavierMatosD marked this pull request as draft February 25, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants