-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[man-group-sparrow] New port #43989
base: master
Are you sure you want to change the base?
[man-group-sparrow] New port #43989
Conversation
Please get failure logs for x64-windows here.
|
When testing usage, the following error occurs:
test.cpp#include <iostream> #include "sparrow/sparrow.hpp" CMakeLists.txtcmake_minimum_required (VERSION 3.8) |
@toge would you be able to name that package "sparrow" rather than "man-group-sparrow"? It is named sparrow on Fedora and conda-forge. Vcpkg using a different name for the package would cause a lot of confusion in my opinion. |
+if("@USE_DATE_POLYFILL@") | ||
+ find_dependency(date) | ||
+endif() | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't hesitate to open a PR on https://github.com/man-group/sparrow/
We can review and merge it asap
OPTIONS | ||
${FEATURE_OPTIONS} | ||
-DBUILD_TESTS=OFF | ||
-DBUILD_EXAMPLES=OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the 0.4 version, you can compile shared library using -DSPARROW_BUILD_SHARED, otherwise it compile in static
vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS | ||
FEATURES | ||
date USE_DATE_POLYFILL | ||
large-int-placeholder USE_LARGE_INT_PLACEHOLDERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
USE_LARGE_INT_PLACEHOLDERS is mandatory on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix for: #43989 (comment)
if(VCPKG_TARGET_IS_LINUX) | ||
message("Warning: `sparrow` requires Clang18+ or GCC 12+ on Linux") | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also MSVC 19.41+ on Windows and Apple Clang 16+ on MacOS
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.There are several
sparrow
pacakges. refsparrow 0.3.0 provides shared library only.