refactor(asset_path#http_prefix): rework to use File.join & array.com…

…pact this implementation contains less code paths & benchmarks a bit faster: https://gist.github.com/stevenosloan/d9b0032500ed4801f0cdd1eb36b9d7b3
middleman · Oct 25, 2016 · 299abd4 · 299abd4
1 parent 24cb47c
commit 299abd4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Gemfile b/Gemfile
@@ -41,4 +41,5 @@ group :test do
   gem 'simplecov',  '~> 0.9',    require: false
   gem 'coveralls',  '~> 0.8',    require: false
   gem 'codeclimate-test-reporter', '~> 0.3', require: false
+  gem 'benchmark-ips'
 end
diff --git a/lib/middleman-sprockets/extension/context_methods.rb b/lib/middleman-sprockets/extension/context_methods.rb
@@ -30,11 +30,13 @@ def asset_path path, options={}
 
           if app.extensions[:sprockets].check_asset(path)
             link_asset(path)
-            prefix = app.config[:http_prefix].nil? ? '/' : app.config[:http_prefix].sub(/\/?$/, '/')
-            app.extensions[:sprockets].sprockets_asset_path(env[path]).sub(/^\/?/, prefix)
+
+            File.join *[app.config[:http_prefix],
+                        app.extensions[:sprockets].sprockets_asset_path(env[path])].compact
           else
             app.asset_path(kind, path)
           end
+
         end
       end
     end