-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMTP settings via url #1360
base: master
Are you sure you want to change the base?
SMTP settings via url #1360
Conversation
2994bd0
to
d5be91d
Compare
a5cf440
to
c7cf494
Compare
Draft-status removed - feedback welcome! |
Nice @eval ! - Please rebase this onto latest master, include a changelog and I'll include it in 2.9 |
546dbf8
to
faacfb3
Compare
Hi @mikel, I updated the PR. I made the following changes:
I tested the setup using mailcatcher and fastmail. |
5508231
to
7360d84
Compare
Updated docs&code to bring in line with the new acceptable values for |
Sorry, but I am not sufficiently familiar with this part of the code to do a review. Please select someone else. |
This PR allows the SMTP-settings to be configured via a url, e.g.
The Travis-builds seemed to fail for reasons unrelated to the code. Fixing this failed so I setup separate builds reachable via the ✅ at https://gitlab.com/eval/mail/tree/smtp-url.
The included smtp-delivery examples for gmail and fastmail were successfully tested.