Issue 113: list enhancements #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
michael-projectx
commented
Nov 7, 2023
michael-projectx
commented
- Addresses issue 113 by allowing inline comments within a list
- Addresses issue 125 by allowing empty lists
* Use by lists defined in structs as well as lists defined in protos
jayv
force-pushed
the
fix/issue-113-list-enhancements
branch
from
a8585c9 to
9d01852
Compare
jayv
force-pushed
the
fix/issue-113-list-enhancements
branch
from
988060d to
5644946
Compare
|
Grammar tests pass, let's add a quick integration test |
FYI found/fixed a segfault with empty lists @michael-projectx |
This was referenced Oct 22, 2024
Closed
This was
linked to
issues
Oct 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.