Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address thread-safety issues by removing backtrace logger #147

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Address thread-safety issues by removing backtrace logger #147

merged 3 commits into from
Oct 23, 2024

Conversation

jayv
Copy link
Collaborator

@jayv jayv commented Oct 22, 2024 •
edited
Loading

The logger maintained a history for logging a backtrace in case of errors, this wasn't thread-safe, rather costly and currently unused so we've decided to remove it.

Fixes #139

This is an alternative to #140 to avoid introducing locks

Before:

image

After:

image

@jayv jayv force-pushed the fix/issue-139-thread-safety-logger branch from 7c81cc3 to 2872071 Compare October 22, 2024 23:40
@jayv
Copy link
Collaborator Author

jayv commented Oct 23, 2024 •
edited
Loading

We keep running into clang-tidy-13 flakyness wrt gtest on ubuntu20 builds. Observing the same in docker as well as on CI. On ubuntu22 I haven't seen it fail the build yet (there is a cmake directive, perhaps this doesn't work reliably on older cmake) . clang-tidy-13 with gtest is an issue AFAIR from clang-tidy-14 it works better. I've moved clang-13 to ubuntu22 to unblock...

image

jayv
jayv commented Oct 23, 2024
View reviewed changes
Dockerfile
@@ -1,115 +1,3 @@
# We only run clang-13 on 20.04 (and whatever ships on its libc), the other compilers run on 22.04
# unfortunately we have to duplicate the postprocessing steps
FROM ubuntu:20.04 AS base-ubuntu20
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop ubuntu 20

jayv
jayv commented Oct 23, 2024
View reviewed changes
Dockerfile
@@ -226,16 +114,6 @@ ENTRYPOINT ["/usr/bin/entrypoint"]

# ----------------------------------------------------------------------------------------------------------------

# 20.04 for clang-13
FROM base-ubuntu20 AS clang-13-ubuntu20
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kept clang-13 with ubuntu 22

@jayv jayv changed the title Address thread-safery issue by removing backtrace logger Address thread-safety issues by removing backtrace logger Oct 23, 2024
@jayv jayv requested a review from kyle-figure October 23, 2024 19:37
michael-projectx
michael-projectx approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@michael-projectx michael-projectx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding the test coverage.

@jayv jayv merged commit 86f5f2c into main Oct 23, 2024
10 checks passed
@jayv jayv mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-projectx michael-projectx michael-projectx approved these changes

@miker2 miker2 Awaiting requested review from miker2

@kyle-figure kyle-figure Awaiting requested review from kyle-figure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thread safety issue traced to logger->log_history
2 participants
@jayv @michael-projectx