update: add support for the new OpenAI embeddings models #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milos Gajdos <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to c2cabd4
- Looked at
16lines of code in1files - Took 29 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. openai/openai.go:8:
- Assessed confidence :
0% - Comment:
The new model constants are correctly defined and follow the existing naming convention. - Reasoning:
The PR is adding support for new OpenAI embeddings models. The changes are straightforward and there doesn't seem to be any logical, performance, or security bugs. The constants are correctly defined and the naming convention is consistent with the existing code.
Workflow ID: wflow_Ut4f7Dz5oPMungjm
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
There was a problem hiding this comment.
👍 Looks good to me!
- Performed an incremental review on cbccf5d
- Looked at
15lines of code in1files - Took 1 minute and 13 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. openai/openai.go:8:
- Assessed confidence :
0% - Comment:
The constants are added correctly and match the naming convention of the existing constant. Good job! - Reasoning:
The PR is straightforward and doesn't seem to introduce any bugs. The constants are added correctly and match the naming convention of the existing constant. There are no logical, performance, or security issues. The code is clean and follows best practices.
Workflow ID: wflow_tnPzbPiFUprHHG1b
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR extends the
Modeltype inopenai.goto support two new OpenAI embeddings models,Text3LargeandText3Small.Key points:
Modeltype inopenai.goto support two new OpenAI embeddings models,Text3LargeandText3Small.Text3LargeandText3Smallconstants toModeltype inopenai.go.Generated with ❤️ by ellipsis.dev