update: renamed openAI model enums and add dimension #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new V3 text embedding models introduced an option dimensions parameter. This adds it to the open AI API payload. We are also renaming the enum variable names for the new models. Signed-off-by: Milos Gajdos <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 29ab810
- Looked at
32lines of code in2files - Took 1 minute and 11 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
2additional comments because they didn't meet confidence threshold of50%.
1. openai/embedding.go:86:
- Assessed confidence :
0% - Comment:
The new field 'Dims' has been added correctly and the comment explaining its usage is clear. Good job! - Reasoning:
The PR author has added a new field 'Dims' to the EmbeddingRequest struct in embedding.go. This field is optional and is only supported in V3 and later. The PR author has also renamed the enum variable names for the new models in openai.go. The changes seem to be in line with the PR description and there doesn't seem to be any logical, performance, or security bugs introduced with these changes.
2. openai/openai.go:8:
- Assessed confidence :
0% - Comment:
The renaming of the enum variable names for the new models is clear and consistent. Good job! - Reasoning:
The PR author has renamed the enum variable names for the new models in openai.go. The changes seem to be in line with the PR description and there doesn't seem to be any logical, performance, or security bugs introduced with these changes.
Workflow ID: wflow_cK33ZlvjOMzJgAqe
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new V3 text embedding models introduced an option dimensions parameter. This adds it to the open AI API payload. We are also renaming the enum variable names for the new models.
Summary:
This PR adds a dimensions field to the
EmbeddingRequeststruct and renames the enum variable names for the new models.Key points:
Dimsfield toEmbeddingRequeststruct inopenai/embedding.go.openai/openai.go.Generated with ❤️ by ellipsis.dev