update: return API embedding response #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally Embeddings method would return an object which was a result of a conversion to a smaller type which only contained the embeddings. This prevents the clients from accessing the API response fields which is not ideal. This commit reverts to returning deserialized API responses and instead provides an exported func in each package that lets the consumers to convert the object into a higher level embedding type defined in the module root. Signed-off-by: Milos Gajdos <[email protected]>
Signed-off-by: Milos Gajdos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally Embeddings method would return an object which was a result of a conversion to a smaller type which only contained the embeddings. This prevents the clients from accessing the API response fields which is not ideal.
This commit reverts to returning deserialized API responses and instead provides an exported func in each package that lets the consumers to convert the object into a higher level embedding type defined in the module root.