Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milvus should be from langchain_milvus.vectorstores #2785

Open
wants to merge 1 commit into
base: v2.4.x
Choose a base branch
from

Conversation

jameswnl
Copy link

Without this change, it will fail with

Invalid Milvus URI: ./milvus_demo.db

But even with this change, it still fail with

pymilvus.exceptions.MilvusException: <MilvusException: (code=2, message=Fail connecting to server on unix:/var/folders/r8/vnb_8wm96j151_t9yms3159c0000gn/T/tmpdudd4706_milvus_demo.db.sock, illegal connection params or server unavailable)>

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jameswnl

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @jameswnl! It looks like this is your first PR to milvus-io/milvus-docs 🎉

@zc277584121
Copy link
Contributor

@jameswnl thanks for your feedback .
https://github.com/langchain-ai/langchain-milvus/blob/main/libs/milvus/langchain_milvus/__init__.py
here the outermost layer declares the Milvus/Zilliz class, so there is no need to from langchain_milvus.vectorstores import Milvus
I think it's other reasons that cause your issues. So far Milvus Lite only support ubunbu >=20.04, and MacOS, can you provide your OS informations, as well as the langchain_milvus, and pymilvus, and milvus-lite versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants