Merge branch 'main' into main

mir-group · Mar 1, 2025 · c31789e · c31789e
2 parents 9b0c377 + 6a6110b
commit c31789e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         python-version: [3.9]
-        torch-version: [1.13.1, "2.*"]
+        torch-version: [1.13.1, 2.5]
 
     steps:
     - uses: actions/checkout@v2

diff --git a/.github/workflows/tests_develop.yml b/.github/workflows/tests_develop.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         python-version: [3.9]
-        torch-version: ["2.*"]
+        torch-version: [2.5]
 
     steps:
     - uses: actions/checkout@v2

diff --git a/nequip/train/early_stopping.py b/nequip/train/early_stopping.py
@@ -74,7 +74,7 @@ def __call__(self, metrics) -> None:
             if minimum is None:
                 self.minimums[key] = value
             elif value >= (minimum - delta):
-                if not self.cumulative_delta and value > minimum:
+                if not self.cumulative_delta and value < minimum:
                     self.minimums[key] = value
                 self.counters[key] += 1
                 debug_args = f"EarlyStopping: {self.counters[key]} / {pat}"