-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add future API #32
Open
rafalp
wants to merge
63
commits into
main
Choose a base branch
from
next-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add future API #32
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
03a389b
Initial next API experiments
rafalp 89a0b96
Minimal working object type
rafalp 67702eb
WIP convert type hint to GraphQL type
rafalp 2fa687e
Basic object and scalar type support
rafalp 5bc9fd7
More API experiments
rafalp 32ba360
Field args names and outnames
rafalp 372428f
Validate graphql name matches schema contents
rafalp 2bb1f4d
WIP deferred fields types
rafalp 64ecdda
Deferred type tests
rafalp 83046b4
Enums support
rafalp 82e5f47
New GraphQLEnum
rafalp 1081c29
Tweak default graphql name from class name for enums
rafalp dfd2f51
More improvements to ObjectType, initial InputType
rafalp 35a91cc
Input types
rafalp c59e62d
Recurrent types, ID type
rafalp ffbbde3
Inputs and objects defaults
rafalp 81d64c0
Input and object instance types
rafalp 2a19874
Update tests
rafalp 07e5c91
GraphQL object types
rafalp 26437c0
WIP finalize make_executable_schema
rafalp e2e9052
Mute too many returns warning
rafalp 1c0fe66
Fix line too long error
rafalp 77be440
next.make_executable_schema
rafalp d94a4f4
Barebones Union type implementation
rafalp b71762b
added-uniont-type-validation
DamianCzajkowski 51d8225
wrap-attributes-names-in-__attrname__-in-error-messages
DamianCzajkowski 2fc3948
updated-error-message
DamianCzajkowski 6b65316
Fix tests suite
rafalp 826bbc5
Base implementation of interface with standarization methods from obj…
DamianCzajkowski 6df9763
Inherit from GraphQLObject in the Interface type
DamianCzajkowski 638fe7b
Small fixes in typing
DamianCzajkowski be15b43
Add more tests to the interface type
DamianCzajkowski b58ac05
Small refactor on interface type
DamianCzajkowski 4a442f7
Add __abstract__ attribute to the interface type
DamianCzajkowski 5b16e12
added subscription model
DamianCzajkowski 7cc8a54
fixed-pylint-issues
DamianCzajkowski ea01834
Fix all mypy issues, Fix all pylint issue, Refactor code
DamianCzajkowski f50a23c
Remove mypy plugin
DamianCzajkowski 3cfe1fa
update-interface-model
DamianCzajkowski ca685ed
run black
DamianCzajkowski b0cc747
fix-UnionTypes-for-python-3.8-3.9
DamianCzajkowski 39327a8
bump-python-to-3.12
DamianCzajkowski f4767f6
black reformat
DamianCzajkowski 05cd2d9
add-compatibility-layer
DamianCzajkowski 89a8002
adjust code to newer changes
DamianCzajkowski d95f2e0
restructure folder layout to make it easier to deploy
DamianCzajkowski bd939b7
fix v1 tests
DamianCzajkowski a2031e8
fix args descriptions
DamianCzajkowski c878df9
Added more tests
DamianCzajkowski c8b141b
add documentation
DamianCzajkowski de7b336
fix for 3.9
DamianCzajkowski 257f0ed
fix staticmethods
DamianCzajkowski ba76514
ignore mypy error
DamianCzajkowski e566ecd
fix pylint and mypy on tests
DamianCzajkowski 8253bcd
fix code for python 3.9
DamianCzajkowski 0ed1284
disable pylint error
DamianCzajkowski 907b38c
introduce ruff
DamianCzajkowski 33bdb2a
add github page deployment
DamianCzajkowski 4c922de
fix test workflow
DamianCzajkowski f41eb63
fix ruff in workflow
DamianCzajkowski 151a733
remove hatch from tests workflow
DamianCzajkowski 92d44a9
fix circular import
DamianCzajkowski 8374a61
change version to dev
DamianCzajkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: Deploy documentation | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
docs-publish: | ||
name: publish documentation | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write | ||
steps: | ||
- name: Checkout source code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version-file: pyproject.toml | ||
|
||
- name: Install Hatch | ||
uses: pypa/hatch@257e27e51a6a5616ed08a39a408a21c35c9931bc | ||
|
||
- name: Build documentation | ||
run: hatch run mkdocs gh-deploy --force |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ariadne in it's readme states 3.7+, should this follow? Even if you are dropping 3.8 here it should be loudly stated in the release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ariadne GraphQL Modules never supported 3.7 due to difference in bound methods handling in Python itself that landed in py3.8.Nevermind. That change happened in Py 3.7 minor release. And we've had two different lists of supported versions, one in
pyproject.toml
and other insetup.py
. One going as far as Py 3.6 and other for Py 3.7. I think its safe to drop 3.7 and 3.8 both here and in other Ariadne libs, but make it first item in release notes.