Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starlette tests #1161

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Fix starlette tests #1161

merged 3 commits into from
Feb 20, 2024

Conversation

rafalp
Copy link
Collaborator

@rafalp rafalp commented Feb 19, 2024

Fixes #1155

@rafalp rafalp added this to the Next release milestone Feb 19, 2024
@rafalp rafalp self-assigned this Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4925c6) 97.87% compared to head (615c0b0) 97.87%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1161   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files         109      109           
  Lines        8052     8052           
=======================================
  Hits         7881     7881           
  Misses        171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafalp rafalp changed the title Add backend="asyncio" to TestClient instances in async tests. Fix starlette tests Feb 20, 2024
@rafalp rafalp merged commit 2ae2146 into main Feb 20, 2024
22 checks passed
@rafalp rafalp deleted the fix-1155-starlette-test-client branch February 20, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starlette integration tests are broken
1 participant